fix(reader): 移动端阅读设置面板补「音量键翻页」开关 / Add missing volume-key paging toggle to mobile reader settings#380
Open
chy5301 wants to merge 1 commit into
Open
Conversation
音量键翻页的核心逻辑、原生桥接、i18n 文案均已就位,但 ReaderSettingsPanel 缺少对应的 toggle,设置项默认 false 且 无 UI 入口可改,导致功能不可达。在「阅读模式」与「顶部 标题与进度」之间插入开关行,复用现有 toggle 模式。 Closes codedogQBY#379
Contributor
Author
|
Hi @codedogQBY，这个 PR 修复的是一个移动端基本可用性问题——音量键翻页的核心逻辑、原生桥接、i18n 文案早已全部就位，唯独设置面板漏接了一个 toggle 开关（默认 移动端阅读场景下，音量键翻页是刚需——单手握持时无需抬手触屏即可翻页，没有这个功能的版本在移动端体验上几乎不可用。改动仅 +12 行，风险极低，请尽快核实确认并合并，建议同步更新版本以尽早覆盖已安装用户。 |
Owner
|
这个有测过了吗？之前音量翻页有奔溃性bug，所以给隐藏了 |
Contributor
Author
|
没特别仔细测，我晚点再看看吧> 这个有测过了吗？之前音量翻页有奔溃性bug，所以给隐藏了 |
Contributor
Author
|
关于这个 PR 卡住的崩溃顾虑，我做了一轮静态源码核查（读了依赖库
（声明：以上为静态分析结论，尚无线上崩溃堆栈实证，建议在 Android 14/15 真机/模拟器 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
移动端音量键翻页的核心逻辑(
useVolumeButtonPaging.ts)、原生桥接(VolumeManager)、启用条件(ReaderScreen.tsx)、设置字段(volumeButtonsPageTurn,默认false)、i18n 文案(settings.volumeButtonsPageTurn)均已就位,唯独ReaderSettingsPanel.tsx缺少对应的开关 UI,导致用户永远无法启用该功能。Closes #379
改动
packages/app-expo/src/screens/reader/ReaderSettingsPanel.tsx(+12 行):readSettings解构新增volumeButtonsPageTurn字段;t("settings.volumeButtonsPageTurn")。无新增依赖、无样式/类型变更。
验证
RubySettingsRow格式警告与本次无关);ReadSettings类型已含volumeButtonsPageTurn(packages/core/src/types/book.ts:95),onUpdateSetting类型安全;